Fix unit tests within active_transactions#3703
Merged
Conversation
clemahieu
reviewed
Feb 1, 2022
| nano::state_block_builder builder; | ||
| auto & node1 = *system.add_node (node_config); | ||
| nano::keypair key{}; | ||
| nano::send_block_builder builder{}; |
Contributor
There was a problem hiding this comment.
This also reverts to legacy blocks.
There was a problem hiding this comment.
perhaps it should be called legacy_send_block_builder to prevent others from making that mistake
Contributor
Author
There was a problem hiding this comment.
Yeah it is a bit unfortunate -- I actually thought we're better off using send_, open_ etc builders since they're more specific, unbeknownst they refer to the legacy block types. Addressed, renaming might be a good idea too, any input on this @clemahieu ?
| send1->serialize (stream); | ||
| } | ||
|
|
||
| // Generate 10 forks to prevent new block insertion to election |
Contributor
There was a problem hiding this comment.
Can you determine why we need to prevent block insertion? It isn't immediately apparent how/why this is done.
Contributor
Author
There was a problem hiding this comment.
I can't say either, let's bring it up
thsfs
approved these changes
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed unit tests:
active_transactions.keep_localactive_transactions.fork_filter_cleanupactive_transactions.fifoNo issues to link to this PR (tests weren't disabled before).