Add optional offset parameter for the receivable RPC#3700
Merged
clemahieu merged 1 commit intonanocurrency:developfrom Feb 3, 2022
Merged
Add optional offset parameter for the receivable RPC#3700clemahieu merged 1 commit intonanocurrency:developfrom
clemahieu merged 1 commit intonanocurrency:developfrom
Conversation
3197828 to
5ebf7c6
Compare
Contributor
Author
|
@dsiganos I forgot to add some small tweaks to the sorting case. Build and tests should be working now. |
clemahieu
approved these changes
Feb 3, 2022
Contributor
|
This looks good but we should really have a unit test for this too. |
Collaborator
@dsiganos Is the unit test done here https://github.com/nanocurrency/nano-node/pull/3700/files#diff-b053a0c38b909565d0ba60ffdfec20e375bb648c815b8088b9c51e6ed22cc71cR1862 incomplete or need to be broken out into a separate test? |
Contributor
|
Doh! I missed that! We are good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3699