Do not ignore socket errors#3694
Merged
dsiganos merged 2 commits intonanocurrency:developfrom Jan 31, 2022
Merged
Conversation
We were not checking the result of the connect, send, recv operations. We assumed that they were successful and treated them as successful, which gave at least wrong stats and possibly other minor problems too.
It seems like a good idea to have counters counting how many tcp errors we get for tcp read, write and connect.
thsfs
requested changes
Jan 28, 2022
Contributor
thsfs
left a comment
There was a problem hiding this comment.
The fix is ok for detecting the socket error and letting the it to get closed, but it seems the stats are getting wrongly registered in the nano::socket::checkup() function.
thsfs
approved these changes
Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not checking the result of the connect, send, recv operations.
We treated failed operations as successful, which
gave at least wrong stats and possibly other minor problems too.
Added counters for tcp connect, read, write errors.