Skip to content

Impove election result logging#3684

Merged
clemahieu merged 1 commit intonanocurrency:developfrom
pwojcikdev:election-result-logging-improvements
Feb 1, 2022
Merged

Impove election result logging#3684
clemahieu merged 1 commit intonanocurrency:developfrom
pwojcikdev:election-result-logging-improvements

Conversation

@pwojcikdev
Copy link
Copy Markdown
Contributor

Right now, node logs result of every election, which makes log not only unreadable but also, in case of logging to terminal, uses surprisingly large amount of gpu to render the text alone. This PR adds a new log configuration option election_result that users can use to configure this behavior. Additionally two new stat types are added that I found very useful to track election results without resorting to staring at text log, nano::stat::detail::election_confirmed and nano::stat::detail::election_not_confirmed.

@pwojcikdev pwojcikdev changed the title Impoved election result logging Impove election result logging Jan 22, 2022
@zhyatt zhyatt added the logging label Jan 24, 2022
Copy link
Copy Markdown
Contributor

@clemahieu clemahieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@clemahieu clemahieu merged commit 1214b2c into nanocurrency:develop Feb 1, 2022
@zhyatt zhyatt added this to the V24.0 milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants