Enable and fix node.unconfirmed_send unit test#3680
Merged
Conversation
dsiganos
reviewed
Jan 20, 2022
dsiganos
reviewed
Jan 20, 2022
nano/core_test/node.cpp
Outdated
| .build_shared (); | ||
| ASSERT_EQ (nano::process_result::progress, node1.ledger.process (node1.store.tx_begin_write (), *send2).code); | ||
| node1.process_confirmed (nano::election_status{ send2 }); | ||
| ASSERT_TIMELY (5s, node1.block_confirmed (send2->hash ())); |
Contributor
There was a problem hiding this comment.
Does node0 get synced at this point?
Is there an election taking place at this point?
I think an overall comment describing those details would be good afterall.
Contributor
Author
|
@reviewers -- addressed CR, please re-review, thanks |
dsiganos
reviewed
Jan 24, 2022
dsiganos
reviewed
Jan 24, 2022
Contributor
Author
|
@dsiganos @clemahieu addressed CR guys, pinging you once more to have a look at this, thanks |
29cbd83 to
854a9be
Compare
dsiganos
approved these changes
Mar 29, 2022
Contributor
Author
|
LGTM, good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't find an issue for this unit test to link it to the PR, perhaps it was disabled way back.