Remove json config code#3655
Merged
clemahieu merged 3 commits intonanocurrency:developfrom Jan 12, 2022
Merged
Conversation
This improves compile/test times a bit. The json->toml upgrade paths are removed as well. In the unlikely case someone needs to upgrade from v19.x and earlier, the solution is to run a v2x node (prior to this change) to perform the upgrade. Closes nanocurrency#3530
clemahieu
previously approved these changes
Jan 11, 2022
dsiganos
reviewed
Jan 11, 2022
dsiganos
reviewed
Jan 11, 2022
Contributor
|
Should we remove |
theohax
previously approved these changes
Jan 11, 2022
Contributor
Author
Yeah good point, will push an update. |
dsiganos
reviewed
Jan 12, 2022
Contributor
|
And I think we can also remove jsonconfig::read_and_update(). |
dsiganos
approved these changes
Jan 12, 2022
Contributor
|
Looks good to me! Thank you for doing the amendments! |
clemahieu
approved these changes
Jan 12, 2022
Contributor
clemahieu
left a comment
There was a problem hiding this comment.
Very nice cleanup. Thank you for pushing this through!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves compile/test times a bit and removes unnecessary code.
The json->toml upgrade paths are removed as well. In the unlikely case someone needs to upgrade from v19.x and earlier, the solution is to run a v2x node (prior to this change) to perform the upgrade.
Closes #3530