Skip to content

Disable batch of intermittently failing unit tests#3629

Merged
theohax merged 1 commit intodevelopfrom
disable-batch-failing-uts
Jan 24, 2022
Merged

Disable batch of intermittently failing unit tests#3629
theohax merged 1 commit intodevelopfrom
disable-batch-failing-uts

Conversation

@theohax
Copy link
Copy Markdown
Contributor

@theohax theohax commented Jan 3, 2022

Disabling a batch of failing unit tests:

  • distributed_work.peer_multi

  • votes.add_old_different_account

  • active_transactions.inactive_votes_cache_multiple_votes

  • confirmation_height.conflict_rollback_cemented

  • active_transactions.confirm_new

  • election.quorum_minimum_flip_success

  • rpc.work_peer_many

  • rpc.work_version_invalid

  • node.vote_by_hash_epoch_block_republish

  • rpc.work_peer_one

  • bootstrap_processor.lazy_unclear_state_link

  • node.pruning_age

  • wallet.process_block

@theohax theohax added bug unit test Related to a new, changed or fixed unit test labels Jan 3, 2022
This was referenced Jan 3, 2022
Open
Open
Closed
Closed
Closed
Closed
Open
Open
Open
Open
Closed
Closed
Open
@zhyatt zhyatt added this to the V24.0 milestone Jan 3, 2022
@dsiganos
Copy link
Copy Markdown
Contributor

dsiganos commented Jan 24, 2022

Most of these tests use scheduler flush so instead of disabling them, we should remove the need to use flush.

@theohax
Copy link
Copy Markdown
Contributor Author

theohax commented Jan 24, 2022

Most of these tests use scheduler flush so instead of disabling them, we should remove the need to use flush.

I would actually disable them and then start on fixing them, fixing is not always that trivial and might take quite some time for all of these.

@theohax theohax merged commit b2d43af into develop Jan 24, 2022
@theohax theohax deleted the disable-batch-failing-uts branch January 24, 2022 15:19
@theohax theohax mentioned this pull request Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thsfs thsfs thsfs approved these changes

@clemahieu clemahieu Awaiting requested review from clemahieu

@dsiganos dsiganos Awaiting requested review from dsiganos

Assignees

No one assigned

Labels

bug unit test Related to a new, changed or fixed unit test

Projects

None yet

Milestone

V24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@theohax @dsiganos @thsfs @zhyatt