Skip to content

Block builders build_shared and use in more tests#2808

Merged
guilhermelawless merged 2 commits intonanocurrency:developfrom
guilhermelawless:blockbuilder/build-shared
Jun 17, 2020
Merged

Block builders build_shared and use in more tests#2808
guilhermelawless merged 2 commits intonanocurrency:developfrom
guilhermelawless:blockbuilder/build-shared

Conversation

@guilhermelawless
Copy link
Copy Markdown
Contributor

  • Adds build_shared() to the abstract builder, so that the caller doesn't have to specify std::shared_ptr<nano::state_block> ..., using auto instead. Keeps tests formatting clean.
  • Use block builders in all active_transactions and node tests from core_test

Used the following script used to convert (95% of cases work without modifications): https://gist.github.com/guilhermelawless/6424ea9199db7584e314381cbce5dc65

@guilhermelawless guilhermelawless added the unit test Related to a new, changed or fixed unit test label Jun 12, 2020
@guilhermelawless guilhermelawless added this to the V22.0 milestone Jun 12, 2020
@guilhermelawless guilhermelawless requested a review from wezrule June 12, 2020 11:28
@guilhermelawless guilhermelawless self-assigned this Jun 12, 2020
@guilhermelawless guilhermelawless force-pushed the blockbuilder/build-shared branch from f847c0c to c8992f0 Compare June 12, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

unit test Related to a new, changed or fixed unit test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants