Framing support for realtime network messages#1972
Merged
SergiySW merged 3 commits intonanocurrency:masterfrom May 14, 2019
Merged
Framing support for realtime network messages#1972SergiySW merged 3 commits intonanocurrency:masterfrom
SergiySW merged 3 commits intonanocurrency:masterfrom
Conversation
Contributor
SergiySW
commented
May 10, 2019
- Sizes addes for each message types & subtypes
- New count field added to message header extensions (4 bit, max size 15) for confirm_req/confirm_ack by hash
- Node ID handshake header flags functions moved to nano::message_header instead from nano::node_id_handshake
- Tests expanded to check count extensions field
- Sizes addes for each message types & subtypes - New count field added to message header extensions (4 bit, max size 15) for confirm_req/confirm_ack by hash - Node ID handshake header flags functions moved to nano::message_header instead from nano::node_id_handshake - Tests expanded to check count extensions field
Contributor
Author
|
Breaking up #1962 |
Contributor
|
If we don't want to expend extension bits, we could maybe retrofit max version to be a count field, since it's not used and doesn't seem useful in the future either. We could then define a count of 0xff to mean "the rest of the count bits follows the header" if we need larger payloads in the future. A new message type to mean "tcp envelope" was also discussed at some point (the payload would be the old header+message), but that probably means too many changes. |
clemahieu
approved these changes
May 10, 2019
Contributor
clemahieu
left a comment
There was a problem hiding this comment.
Looks good after some small modifications.
cryptocode
approved these changes
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.