github: Fix exit code of nightly check_commits step#2046
Merged
Conversation
After the nightly workflow was changed to skip when no commits were merged to master, the check step returned a non-zero exit code in the "commits exist" case and caused the run to fail instead of proceeding to the tests. Rewrite it as a plain 'if' so the step always exits cleanly and only sets should_run=false when there really are no recent commits. Signed-off-by: Jun Yeong Kim <junyeonggim5@gmail.com>
Contributor
Author
|
Hi @namhyung, I just noticed the nightly test failed. Please take a look. |
namhyung
approved these changes
May 12, 2026
namhyung
left a comment
Owner
There was a problem hiding this comment.
LGTM, thanks for the quick fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the nightly workflow was changed to skip when no commits were merged to master, the check step returned a non-zero exit code in the "commits exist" case and caused the run to fail instead of proceeding to the tests. Rewrite it as a plain 'if' so the step always exits cleanly and only sets should_run=false when there really are no recent commits.