symbol: Fix build error in elf_for_each_comment()#2034
Merged
Conversation
The elf_for_each_comment() macro incorrectly used strcmp() instead of strlen() when calculating the next comment offset. This caused a compilation error when libelf was not present and the internal ELF parser was used. Fix namhyung#2033 Signed-off-by: Jun Yeong Kim <junyeonggim5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the issue that I opened #2033
The elf_for_each_comment() macro incorrectly used strcmp() instead of strlen() when calculating the next comment offset. This caused a compilation error when libelf was not present and the internal ELF parser was used.