test: exclude system_initialize_function in t295 and t296 using filter option#2001
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors test logic in t295 and t296 by replacing manual exclusions for system initialization functions with a filter option, thereby simplifying and standardizing the exclusion process.
- Removed explicit filtering of '__monstartup' and '__cxa_atexit' from conversion functions
- Updated the option string in test setup to include the '-F main' filter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/t296_graph_field_self.py | Removed manual filtering and added filter option in test setup |
| tests/t295_graph_field_total.py | Removed manual filtering and added filter option in test setup |
Comments suppressed due to low confidence (2)
tests/t296_graph_field_self.py:28
- Verify that the filter option '-F main' reliably excludes the system initialization functions as intended.
self.option = '-F main -f self-avg,self-max,self-min'
tests/t295_graph_field_total.py:28
- Verify that the filter option '-F main' reliably excludes the system initialization functions as intended.
self.option = '-F main -f total-avg,total-max,total-min'
honggyukim
approved these changes
Jun 16, 2025
honggyukim
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for your patch. I feel the commit title is too long so I would like to ask to change the commit title to the following.
tests: Fix unexpected failures of 295, 296 with -F main filter
But it's not a problem blocking this PR so LGTM!
Previously, t295 and t296 excluded system_initialize_function
by filtering its name in the test logic.
This change moves that logic to use the Filter option instead,
making the exclusion cleaner and more consistent.
========== FUNCTION CALL GRAPH ==========
TOTAL AVG TOTAL MAX TOTAL MIN FUNCTION
10.758 ms 10.758 ms 10.758 ms : (1) t-sort
10.758 ms 10.758 ms 10.758 ms : (1) main
139.750 us 262.084 us 17.416 us : +-(2) foo
10.305 us 31.875 us 5.083 us : | (6) loop
: |
10.357 ms 10.357 ms 10.357 ms : +-(1) bar
10.172 ms 10.172 ms 10.172 ms : (1) usleep
$ make -j 8 test TESTARG=graph_field
Running 0 test cases
======================
unit test stats
====================
0 ran successfully
0 failed
0 skipped
0 signal caught
0 unknown result
TEST test_all
Start 2 tests with 2 worker
Compiler gcc
Runtime test case pg finstrument-fu fpatchable-fun
------------------------: O0 O1 O2 O3 Os O0 O1 O2 O3 Os O0 O1 O2 O3 Os
295 graph_field_total : OK OK OK OK OK OK OK OK OK OK OK OK OK OK OK
296 graph_field_self : OK OK OK OK OK OK OK OK OK OK OK OK OK OK OK
Signed-off-by: Jun Yeong Kim <junyeonggim5@gmail.com>
Contributor
Author
|
I have revised the commit title based on your review. Thank you for your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, t295 and t296 excluded system_initialize_function
by filtering its name in the test logic.
This change moves that logic to use the Filter option instead,
making the exclusion cleaner and more consistent.