Skip to content

Dependencies upgrade#161

Merged
zjkmxy merged 1 commit intonamed-data:mainfrom
zjkmxy:main
Oct 13, 2025
Merged

Dependencies upgrade#161
zjkmxy merged 1 commit intonamed-data:mainfrom
zjkmxy:main

Conversation

@zjkmxy
Copy link
Member

@zjkmxy zjkmxy commented Oct 12, 2025

Fix: #160

@zjkmxy zjkmxy requested a review from Copilot October 12, 2025 23:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades project dependencies and addresses security concerns by updating RSA key sizes and dependencies.

  • Updates Go version from 1.23.0 to 1.24.0 with toolchain 1.24.3
  • Upgrades multiple dependencies including badger, quic-go, and golang.org/x packages
  • Increases minimum RSA key size from 512 bits to 1024 bits in security tests

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
go.mod Updates Go version and upgrades dependencies to newer versions
std/security/signer/validate_test.go Changes RSA test key size from 512 to 1024 bits
std/security/signer/marshal_test.go Replaces 512-bit RSA test key with 1024-bit key

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zjkmxy zjkmxy requested a review from pulsejet October 12, 2025 23:49
@zjkmxy zjkmxy merged commit 62fdead into named-data:main Oct 13, 2025
9 checks passed
@zjkmxy
Copy link
Member Author

zjkmxy commented Oct 13, 2025

Don't think this will cause any issue so just merge.
The only concern is that RSA keys with <= 1024 bits will cause a panic with warnings telling you to use a longer key/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants