trust_config: bail if the data is a cert and is not fresh#156
Merged
a-thieme merged 2 commits intonamed-data:mainfrom Jul 11, 2025
tianyuan129:main
Merged
trust_config: bail if the data is a cert and is not fresh#156a-thieme merged 2 commits intonamed-data:mainfrom tianyuan129:main
a-thieme merged 2 commits intonamed-data:mainfrom
tianyuan129:main
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements certificate expiration validation to resolve issue #155, adding a check to reject expired certificates during trust validation. The changes include:
- Added certificate expiration checking in the trust validation flow
- Enhanced test infrastructure to support certificate expiration testing
- Added comprehensive tests for both valid and expired certificates
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| std/security/trust_config.go | Added certificate expiration validation logic in the Validate method |
| std/security/trust_config_test.go | Enhanced helper functions and added test cases for expired certificates |
std/security/trust_config_test.go
Outdated
Comment on lines
+474
to
+477
| _, eveExpiredCertData, exeExpiredSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), expiredOpts) | ||
| _, eveCertData, exeSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | ||
| require.True(t, validateCerts(eveCertData, exeSigCov)) | ||
| require.False(t, validateCerts(eveExpiredCertData, exeExpiredSigCov)) |
There was a problem hiding this comment.
Variable name 'exeExpiredSigCov' appears to be a typo. It should be 'eveExpiredSigCov' to match the naming convention used for Eve's certificate.
Suggested change
| _, eveExpiredCertData, exeExpiredSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), expiredOpts) | |
| _, eveCertData, exeSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | |
| require.True(t, validateCerts(eveCertData, exeSigCov)) | |
| require.False(t, validateCerts(eveExpiredCertData, exeExpiredSigCov)) | |
| _, eveExpiredCertData, eveExpiredSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), expiredOpts) | |
| _, eveCertData, exeSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | |
| require.True(t, validateCerts(eveCertData, exeSigCov)) | |
| require.False(t, validateCerts(eveExpiredCertData, eveExpiredSigCov)) |
std/security/trust_config_test.go
Outdated
Comment on lines
+475
to
+476
| _, eveCertData, exeSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | ||
| require.True(t, validateCerts(eveCertData, exeSigCov)) |
There was a problem hiding this comment.
Variable name 'exeSigCov' appears to be a typo. It should be 'eveSigCov' to match the naming convention used for Eve's certificate.
Suggested change
| _, eveCertData, exeSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | |
| require.True(t, validateCerts(eveCertData, exeSigCov)) | |
| _, eveCertData, eveSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | |
| require.True(t, validateCerts(eveCertData, eveSigCov)) |
std/security/trust_config_test.go
Outdated
Comment on lines
+475
to
+476
| _, eveCertData, exeSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | ||
| require.True(t, validateCerts(eveCertData, exeSigCov)) |
There was a problem hiding this comment.
Variable name 'exeSigCov' appears to be a typo. It should be 'eveSigCov' to match the naming convention used for Eve's certificate.
Suggested change
| _, eveCertData, exeSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | |
| require.True(t, validateCerts(eveCertData, exeSigCov)) | |
| _, eveCertData, eveSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | |
| require.True(t, validateCerts(eveCertData, eveSigCov)) |
std/security/trust_config_test.go
Outdated
Comment on lines
+474
to
+477
| _, eveExpiredCertData, exeExpiredSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), expiredOpts) | ||
| _, eveCertData, exeSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | ||
| require.True(t, validateCerts(eveCertData, exeSigCov)) | ||
| require.False(t, validateCerts(eveExpiredCertData, exeExpiredSigCov)) |
There was a problem hiding this comment.
Variable name 'exeExpiredSigCov' appears to be a typo. It should be 'eveExpiredSigCov' to match the naming convention used for Eve's certificate.
Suggested change
| _, eveExpiredCertData, exeExpiredSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), expiredOpts) | |
| _, eveCertData, exeSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | |
| require.True(t, validateCerts(eveCertData, exeSigCov)) | |
| require.False(t, validateCerts(eveExpiredCertData, exeExpiredSigCov)) | |
| _, eveExpiredCertData, eveExpiredSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), expiredOpts) | |
| _, eveCertData, exeSigCov := signCert(rootSigner, tu.NoErr(signer.MarshalSecret(eveSigner)), opts) | |
| require.True(t, validateCerts(eveCertData, exeSigCov)) | |
| require.False(t, validateCerts(eveExpiredCertData, eveExpiredSigCov)) |
std/security/trust_config_test.go
Outdated
| // This cross schema should not be accepted | ||
| require.False(t, validateSyncWithCross("/test/alice/app/test/bob/data1", bobSigner, bobMCross)) | ||
|
|
||
| // ------------- Eve (certifcates only) ------------- |
There was a problem hiding this comment.
Spelling error in comment: 'certifcates' should be 'certificates'.
Suggested change
| // ------------- Eve (certifcates only) ------------- | |
| // ------------- Eve (certificates only) ------------- |
zjkmxy
approved these changes
Jul 11, 2025
Member
|
Copilot caught some typos but I think it does not matter. Please merge yourself when you feel ready. |
Collaborator
Author
|
I don't have merge access 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve #155