Switch default socket to /var/run/nfd/nfd.sock on Mac#147
Merged
zjkmxy merged 3 commits intonamed-data:mainfrom May 2, 2025
Merged
Switch default socket to /var/run/nfd/nfd.sock on Mac#147zjkmxy merged 3 commits intonamed-data:mainfrom
zjkmxy merged 3 commits intonamed-data:mainfrom
Conversation
zjkmxy
approved these changes
May 2, 2025
fw/yanfd.sample.yml
Outdated
| # Whether to enable Unix stream transports | ||
| enabled: true | ||
| # Location of the socket file | ||
| ## If running on Mac, use /var/run/nfd/nfd.sock |
Member
There was a problem hiding this comment.
nit: Maybe add another line explaining on Windows it is ${TEMP}\\nfd\\nfd.sock
Pesa
reviewed
May 2, 2025
fw/yanfd.sample.yml
Outdated
| enabled: true | ||
| # Location of the socket file | ||
| ## If running on Mac, use /var/run/nfd/nfd.sock | ||
| socket_path: /run/nfd/nfd.sock |
Member
There was a problem hiding this comment.
maybe this setting should be commented out in the sample so that it falls back to the default which works out of the box on all platforms?
Contributor
Author
There was a problem hiding this comment.
This makes sense, thanks! I'll add a comment like @zjkmxy mentioned above as well in case they want to manually set it
Contributor
Author
There was a problem hiding this comment.
Commented out the line, and explained how the path is set on Windows vs Mac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#144
Checks operating system before choosing socket file.
If on Mac, use /var/run/nfd/nfd.sock
Otherwise, use /run/nfd/nfd.sock
Fixes an issue where Mac gives a permission denied error when trying to create a file in the /run folder.