face: introduce HTTP/3 WebTransport listener#138
Merged
zjkmxy merged 1 commit intonamed-data:mainfrom Apr 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for an HTTP/3 WebTransport listener to the application.
- Introduces HTTP/3 configuration in the YAML and core config files.
- Implements new HTTP3Transport and HTTP3Listener types to handle WebTransport sessions.
- Updates URI handling to support the new "quic" scheme and integrates the listener in the command startup.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| fw/yanfd.sample.yml | Adds HTTP3 configuration section. |
| fw/face/http3-transport.go | Implements transport logic for HTTP/3 WebTransport connections. |
| fw/face/http3-listener.go | Introduces the listener for HTTP/3 WebTransport sessions. |
| fw/defn/uri.go | Adds support for generating QUIC/HTTP3 URIs and updates URI decoding. |
| fw/defn/uri_test.go | Extends tests to cover the new QUIC URI format. |
| fw/core/config.go | Extends configuration to include HTTP3 settings. |
| fw/cmd/yanfd.go | Integrates HTTP3 listener instantiation into the server startup flow. |
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (2)
fw/face/http3-listener.go:98
- [nitpick] Consider logging or otherwise handling the error from l.server.Upgrade to aid troubleshooting when the upgrade fails.
if e != nil { return }
fw/defn/uri_test.go:88
- [nitpick] Expand test coverage for QUIC URIs to verify that canonical properties and proper URI string formatting are maintained, as done for other protocols.
uri = defn.DecodeURIString("quic://[::1]:443")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.