[cleanup][misc] Fix imports using shaded dependencies#3
Closed
nahguam wants to merge 1 commit into
Closed
Conversation
14 tasks
0efca47 to
668c31c
Compare
47fca4f to
10df980
Compare
## Motivation Some usages of Guava and Awaitility are coming from the versions shaded in Curator and Testcontainers respectively. ## Modifications * Use the correct Guava imports. * Use the correct Awaitility imports. * Remove Maps.newHashMap due to modernizer-maven-plugin error * Add shaded packages to checkstyle IllegalImports
10df980 to
f0c0b20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some usages of Guava and Awaitility are coming from the versions shaded in
Curator and Testcontainers respectively.
Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: