Template layer for radio HW abstraction#210
Merged
Conversation
Contributor
|
Memory usage change @ ecba37c
Click for full report table
Click for full report CSV |
Member
Author
|
That size report is interesting. Good to know these changes don't negatively affect the nano. |
TMRh20
approved these changes
Jun 7, 2023
fix arduino CI
using typedef RF24Network instead ensures no major breakage
- uniforms template param names - add nRF52833 chip to ifdefs
self reviewed a bit
Member
Author
|
tested on PicoSDK and Linux python wrapper ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #204
This layer was unique in that I had to re-write the python wrapper to allow for using the renamed template class. Everything else is typical template implementation.
RF24Networkis now a backward compatible type definition that aliases theRF24specialization of theESBNetworkclass.RF52Networkis a type definition that aliases thenrf_to_nrfspecialization of theESBNetworkclass.