restructure project to a more modern project structure - fixes #126#129
Merged
milkshakeuk merged 1 commit intomasterfrom Nov 26, 2020
Merged
restructure project to a more modern project structure - fixes #126#129milkshakeuk merged 1 commit intomasterfrom
milkshakeuk merged 1 commit intomasterfrom
Conversation
Member
Author
|
@duaneedwards @Usualdosage @ryankelley is anyone able to look at this? |
Member
Author
|
@duaneedwards @Usualdosage @ryankelley has anyone managed to have a look at this yet? |
Collaborator
duaneedwards
left a comment
There was a problem hiding this comment.
Looks good to me, though it's a huge merge request and GitHub is buckling under all the modified files :-s
Given the nature of the change I think it would be best to get approval by @Usualdosage before merging.
Collaborator
|
Monster merge, I can't see anything wrong with changing the structure. Makes sense to me. Fire away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #126
@jakubsuchybio