Add .vs into .gitignore file to ignore Visual Studio files#102
Closed
jakubsuchybio wants to merge 2 commits intonHapiNET:masterfrom
jakubsuchybio:master
Closed
Add .vs into .gitignore file to ignore Visual Studio files#102jakubsuchybio wants to merge 2 commits intonHapiNET:masterfrom jakubsuchybio:master
jakubsuchybio wants to merge 2 commits intonHapiNET:masterfrom
jakubsuchybio:master
Conversation
dreaminhex
reviewed
Oct 22, 2020
| try | ||
| { | ||
| string[] dateFormats = new string[] {LongDateTimeFormat, ShortDateTimeFormat, LongDateTimeFormatWithSecond, LongDateTimeFormatWithOffset }; | ||
| string[] dateFormats = new string[] {LongDateTimeFormat, ShortDateTimeFormat, LongDateTimeFormatWithSecond, LongDateTimeFormatWithOffset, LongDateTimeFormatWithFactionOfSecond }; |
Collaborator
There was a problem hiding this comment.
This file should not be included if the purpose is just to remove the .vs folder. Remove this file and and create a separate PR for this file.
dreaminhex
suggested changes
Oct 22, 2020
Collaborator
dreaminhex
left a comment
There was a problem hiding this comment.
Remove file NHapi20/NHapi.Base/Model/Primitive/TSComponentOne.cs from this PR as it's not related to removal of the .vs folder. If you want to make changes to this file, open a new PR describing the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just after cloning your repo. In git status I get .vs untracked changes. So this will remedy that. There is no need to have .vs folder in repository.