Fix EEPROM detection Joybus status response#203
Merged
sp1187 merged 3 commits inton64dev:masterfrom Jun 26, 2021
Merged
Conversation
This was referenced Jun 23, 2021
Based on EEPROM test ROM run on real hardware.
408a9c7 to
8c461e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proper fix for workaround in DragonMinded/libdragon#125 (review)
@rasky @sp1187
These response values have been confirmed on real hardware using the following test ROM which dumps the EEPROM status input and output data: eepromtest.zip
The same test ROM was used to verify these changes.