fix(iroh-relay): Turn off nagle for relayed streams in iroh-relay servers#3995
Merged
dignifiedquire merged 2 commits intomainfrom Mar 9, 2026
Merged
fix(iroh-relay): Turn off nagle for relayed streams in iroh-relay servers#3995dignifiedquire merged 2 commits intomainfrom
dignifiedquire merged 2 commits intomainfrom
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3995/docs/iroh/ Last updated: 2026-03-04T16:59:19Z |
flub
approved these changes
Mar 6, 2026
Member
Author
|
This gives me a very consistent, major performance improvement for local relayed iroh throughput: This branch: main: I see very little fluctuation in these numbers from run-to-run (all within 10%). Let's ship this! Thank you for identifying this issue @ISensuiI ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3974
We already turn off nagle in iroh-relay clients. Turning it off in servers also seems sensible, given we mostly send around nicely-packaged data and aim for low latency.
Notes & open questions
Would love thoughts & experiences from others. I'm not sure how common setting this on servers is.
We should probably also benchmark this.
Change checklist