Skip to content

refactor(iroh-dns-server): move block from select! to fn#3597

Merged
Frando merged 1 commit intoFrando/n0-errorfrom
Frando/dns-server-actor-handle-message
Nov 3, 2025
Merged

refactor(iroh-dns-server): move block from select! to fn#3597
Frando merged 1 commit intoFrando/n0-errorfrom
Frando/dns-server-actor-handle-message

Conversation

@Frando
Copy link
Copy Markdown
Member

@Frando Frando commented Nov 3, 2025 •
edited
Loading

Description

cargo fmt can't handle code inside tokio::select! and the big match statement had numerous formatting issues, so I moved it into a function.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

@Frando Frando marked this pull request as ready for review November 3, 2025 08:59
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 3, 2025 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3597/docs/iroh/

Last updated: 2025-11-03T09:56:13Z

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 3, 2025 •
edited
Loading

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: a3036d6

@n0bot n0bot bot added this to iroh Nov 3, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Nov 3, 2025
@Frando Frando force-pushed the Frando/dns-server-actor-handle-message branch from 73a05ff to d863809 Compare November 3, 2025 09:54
@Frando Frando merged commit 9667f8b into Frando/n0-error Nov 3, 2025
26 of 28 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flub flub flub approved these changes

@dignifiedquire dignifiedquire dignifiedquire approved these changes

@matheus23 matheus23 matheus23 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

iroh
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Frando @flub @dignifiedquire @matheus23