Conversation
da3630d to
55c35d7
Compare
Contributor
Let's add the batching asap, since I am currently finding out that adding it to a big code base like iroh-sync is no fun at all. But it does not have to happen in this PR. |
rklaehn
approved these changes
Apr 11, 2024
Contributor
rklaehn
left a comment
There was a problem hiding this comment.
This just adds the iroh-dns-server to the iroh repo.
It has been relatively thoroughly reviewed in n0-computer/iroh-dns-server#5
So I think we should just merge this and do small adjustments in subsequent PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Imports https://github.com/n0-computer/iroh-dns-server into this repo.
See n0-computer/iroh-dns-server#5 for previous review/discussion.
Now includes an integration smoke test in
iroh-dns-server/src/lib.rs.Notes & open questions
I think I addressed most review points that came up in the initial review. Prominently still open is:
redbstore is used from async context but only exposes a sync interface (redb default). I think this is fine for medium load. However for better performance we should reuse transactions, which likely means we need an actor on a separate thread, as we do in iroh-bytes and iroh-sync.Change checklist