feat(iroh): add tracing events for connections#4021
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4021/docs/iroh/ Last updated: 2026-03-13T11:16:22Z |
flub
approved these changes
Mar 13, 2026
Contributor
flub
left a comment
There was a problem hiding this comment.
yay for more people getting use out of the events!
| } | ||
| } | ||
| fn handle_connection_close(&mut self, conn_id: ConnId) { | ||
| fn handle_connection_close(&mut self, conn_id: ConnId, reason: ConnectionError) { |
Contributor
There was a problem hiding this comment.
could we add the random missing newline in front of this while we're here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds
iroh::_event::connevents for incoming and outgoing connections. We already have path events, but no connection events, so this makes our event system more complete, and gives good context when readingiroh::_events.