fix: increase DNS timeout and address lookup stagger intervals#4008
fix: increase DNS timeout and address lookup stagger intervals#4008
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4008/docs/iroh/ Last updated: 2026-03-11T14:04:18Z |
iroh/src/address_lookup/dns.rs
Outdated
| ) -> Option<BoxStream<Result<AddressLookupItem, AddressLookupError>>> { | ||
| let resolver = self.dns_resolver.clone(); | ||
| let origin_domain = self.origin_domain.clone(); | ||
| let span = debug_span!("DnsAddressLookup", id=%endpoint_id.fmt_short(), %origin_domain); |
There was a problem hiding this comment.
The id logged is the one of the endpoint being looked up? Can we make that a bit clearer? Maybe lookup_id or query_id or so? I'm not entirely sure.
iroh-relay/src/defaults.rs
Outdated
| /// Default timeout for DNS queries issued by [`DnsResolver`]. | ||
| /// | ||
| /// [`DnsResolver`]: crate::dns::DnsResolver | ||
| pub const DNS_TIMEOUT: Duration = Duration::from_secs(3); |
There was a problem hiding this comment.
Eh, not sure I agree with this. Just to make the docs happy is not enough of a reason to make something pub. I would rather just hardcode the value in the docs.
There was a problem hiding this comment.
Right, I can revert. I thought it might still be useful, because downstream code might want to do calculations with this timeout. I.e. apply their own timeouts by adding something to this value. But can also revert, dunno?
There was a problem hiding this comment.
Please revert. It is unrelated to the thing we're fixing here and this is kind of a hotfix. So it's always better to keep the changes minimal even if we eventually decide to make this pub for some good reason.
Description
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme