chore(iroh): Update noq commit, stop exposing AeadKey#4003
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4003/docs/iroh/ Last updated: 2026-03-09T09:46:00Z |
dignifiedquire
approved these changes
Mar 9, 2026
Contributor
|
this is a breaking change, no? please document if so properly |
Member
Author
There already is a section in the breaking changes list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates to the latest noq
mainbranch.noqrecently stopped exposingtrait AeadKey, because thetrait HandshakeTokenKeydoesn't have a function returningBox<dyn AeadKey>anymore (instead it is left up to the implementation to use appropriate AEAD constructions with or without an HKDF in front).(Also fix the iroh unit test suite to allow compiling without the
metricsfeature.)Breaking Changes
trait AeadKeyand changetrait HandshakeTokenKeyto implementsealandopenon its own, leaving choice of using an HKDF to the user.