deps: Prefer portable_atomic over native AtomicU64#3994
Merged
Conversation
On some 32 bit platforms there is no AtomicU64. Portable_atomic uses the underlying atomic on 64 bit platforms, so there is no perf overhead on those. We already have portable_atomic in the deps,
991ee28 to
5d2263a
Compare
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3994/docs/iroh/ Last updated: 2026-03-04T14:00:53Z |
dignifiedquire
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On some 32 bit platforms there is no AtomicU64. Portable_atomic uses the underlying atomic on 64 bit platforms, so there is no perf overhead on those.
We already have portable_atomic in the deps, from moka and once_cell. So there is no additional dependency cost.
This is needed to get iroh to work on 32 bit platforms without native support for AtomicU64.
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme