Skip to content

deps: Remove process and signal tokio features#3993

Merged
rklaehn merged 1 commit intomainfrom
reduced-deps
Mar 4, 2026
Merged

deps: Remove process and signal tokio features#3993
rklaehn merged 1 commit intomainfrom
reduced-deps

Conversation

@rklaehn
Copy link
Copy Markdown
Contributor

@rklaehn rklaehn commented Mar 4, 2026 •
edited
Loading

Description

They are not needed except for the binary, and especially signal pulls in some stuff that causes trouble on some weird platforms.

Breaking Changes

None? I mean strictly speaking we could break a build since we now have fewer tokio features. But is that considered breaking?

Notes & open questions

Note: this is fallout from my (successful) attempt to get iroh to run on an ESP32.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

@rklaehn
Remove process and signal dependency.
293161f 
They are not needed except for the binary, and especially signal pulls in
some stuff that causes trouble on some weird platforms.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2026

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3993/docs/iroh/

Last updated: 2026-03-04T13:32:18Z

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2026

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: a62b047

@rklaehn rklaehn marked this pull request as ready for review March 4, 2026 13:39
@rklaehn rklaehn mentioned this pull request Mar 4, 2026
Open
10 tasks
@n0bot n0bot bot added this to iroh Mar 4, 2026
@github-project-automation github-project-automation bot moved this to 🚑 Needs Triage in iroh Mar 4, 2026
@rklaehn rklaehn added this pull request to the merge queue Mar 4, 2026
Merged via the queue into main with commit 086c6e8 Mar 4, 2026
29 of 30 checks passed
@github-project-automation github-project-automation bot moved this from 🚑 Needs Triage to ✅ Done in iroh Mar 4, 2026
@rklaehn rklaehn deleted the reduced-deps branch March 5, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees

No one assigned

Labels

None yet

Projects

iroh
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rklaehn @dignifiedquire