refactor: update quinn and simplify path handling in RemoteStateActor#3967
Merged
refactor: update quinn and simplify path handling in RemoteStateActor#3967
RemoteStateActor#3967Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3967/docs/iroh/ Last updated: 2026-02-24T19:41:40Z |
RemoteStateActor
flub
requested changes
Feb 24, 2026
| let Some(path_remote) = conn_state.paths.get(&id).cloned() else { | ||
| debug!("path not in path_id_map"); | ||
| PathEvent::Abandoned { id, .. } => { | ||
| // This is the last event for this path: remove from conn_state. |
Contributor
There was a problem hiding this comment.
erm, no, the discarded event is still emitted...
Maybe "From now on we no longer want to use this path" or something. Or... nothing?
| self.paths.abandoned_path(&path_remote); | ||
|
|
||
| event!( | ||
| target: "iroh::_events::path::closed", |
Contributor
There was a problem hiding this comment.
let's rename this to abandoned too. the events are internal debugging tools, not user-facing. so let's keep them as specific and accurate as possible.
flub
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mainas of now.RemoteStateActor'sConnectionStateonly track open paths. We never accessed the list of non-open paths, so it seems much simpler to me to only track what we need.Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme