Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3957/docs/iroh/ Last updated: 2026-02-19T09:29:06Z |
flub
approved these changes
Feb 19, 2026
| run: | | ||
| cp -r .github/sims/iroh/ ../chuck/netsim/sims/iroh/ | ||
| cp -r .github/sims/integration/ ../chuck/netsim/sims/integration/ | ||
| cp -r .github/sims/paused/ ../chuck/netsim/sims/paused/ |
Contributor
There was a problem hiding this comment.
So this is because netsim still checks in it's own hardcoded paths? I guess netsim could take the files to look at as an argument somehow, which might be a bit cleaner. But this will also work.
Collaborator
Author
There was a problem hiding this comment.
It does take paths as arguments. This was to preserve the old structure. I intend to do another cleanup pass on netsim in the near future now that it's getting some love. I want to move netsim up and rename chuck to netsim and do some other cleanup which would include reworking these flows a little too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We've done this in the quinn repo already. This should make life easier to both fiddle with sims while working but also to easily sync up changes when needed instead of having to sync merges across repos. Netsim itself changes less frequently and also is a lot more decoupled and tolerant of moving independently this way.
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme