Skip to content

feat(netsim): filter tests#3946

Merged
dignifiedquire merged 4 commits intomainfrom
arqu/netsim_test_filtering
Feb 16, 2026
Merged

feat(netsim): filter tests#3946
dignifiedquire merged 4 commits intomainfrom
arqu/netsim_test_filtering

Conversation

@Arqu
Copy link
Copy Markdown
Collaborator

@Arqu Arqu commented Feb 16, 2026 •
edited
Loading

Description

Improves on the current filtering logistics of netsim. Instead of just a skiplist, you now have a filter field. Depending on prefix you either run it:

  • empty - no filtering
  • prefix the list with skip: to skip specific tests in a run
  • prefix the list with only: to only run specific tests
  • defaults to only: if you just provide a list without a prefix

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

@Arqu Arqu self-assigned this Feb 16, 2026
@Arqu Arqu added this to iroh Feb 16, 2026
@github-project-automation github-project-automation bot moved this to 🚑 Needs Triage in iroh Feb 16, 2026
@Arqu Arqu added the test label Feb 16, 2026
@Arqu Arqu requested review from dignifiedquire and flub February 16, 2026 07:42
@Arqu Arqu moved this from 🚑 Needs Triage to 👀 In review in iroh Feb 16, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 16, 2026 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3946/docs/iroh/

Last updated: 2026-02-16T17:17:30Z

flub
flub approved these changes Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the skip and only filtering do submatches or only full matches? that is is only:nat eqvallent to only:*nat* or would it not run anything.

I think it could make sense to do submatches, but also probably not too much trial-and-error to get the names correct otherwise.

@Arqu Arqu enabled auto-merge February 16, 2026 08:22
@Arqu
Copy link
Copy Markdown
Collaborator Author

Arqu commented Feb 16, 2026

I'll get that going on the netsim side

@Arqu
Copy link
Copy Markdown
Collaborator Author

Arqu commented Feb 16, 2026

Done, matches on substring now
n0-computer/chuck@975cafd

@dignifiedquire dignifiedquire merged commit 1729243 into main Feb 16, 2026
27 of 29 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in iroh Feb 16, 2026
@dignifiedquire dignifiedquire deleted the arqu/netsim_test_filtering branch February 16, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flub flub flub approved these changes

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

Assignees

@Arqu Arqu

Labels

test

Projects

iroh
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Arqu @flub @dignifiedquire