feat(relay,dns): add healthz routes#3783
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3783/docs/iroh/ Last updated: 2025-12-17T12:44:46Z |
iroh-dns-server/src/http.rs
Outdated
| http_requests_error: state.metrics.http_requests_error.get(), | ||
| dns_requests: state.metrics.dns_requests.get(), | ||
| dns_lookup_success: state.metrics.dns_lookup_success.get(), | ||
| dns_lookup_notfound: state.metrics.dns_lookup_notfound.get(), |
There was a problem hiding this comment.
that's a lot of details you are making publicly accessible, seems potentially risky
There was a problem hiding this comment.
hmmm fair, they are all available on the metrics side, maybe just nuke those and keep the version info
flub
left a comment
There was a problem hiding this comment.
Definitely in favour of doing this, but would prefer if we did as little as possible in the build.rs and remove all the unused features.
iroh-dns-server/build.rs
Outdated
| fn emit_vergen() -> Result<(), Box<dyn std::error::Error>> { | ||
| let build = BuildBuilder::all_build()?; | ||
| let cargo = CargoBuilder::all_cargo()?; | ||
| let gitcl = GitclBuilder::all_git()?; |
There was a problem hiding this comment.
Given we only use this, why not disable all the features on the crate and only use this?
Additionally all_git() seems like it has to invoke a whole bunch of git commands, maybe just sha() would be lighter as well?
flub
left a comment
There was a problem hiding this comment.
i swear i did approve this before... weird
Description
We're missing some basic service utilities. I kept this simple and just set it all to the
/healthzroute.Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme