feat: expose known remote addrs#3752
Merged
Frando merged 7 commits intofeat-multipathfrom Dec 15, 2025
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3752/docs/iroh/ Last updated: 2025-12-12T14:05:02Z |
Frando
commented
Dec 9, 2025
91b4756 to
4449690
Compare
dignifiedquire
approved these changes
Dec 9, 2025
Contributor
dignifiedquire
left a comment
There was a problem hiding this comment.
given how easy it is to implement this, and how useful this is for users, I would say, lets do this
93612f5 to
299d985
Compare
flub
reviewed
Dec 10, 2025
Contributor
flub
left a comment
There was a problem hiding this comment.
As usual I'm anxious about creating any API surface and am arguing to make it smaller 😁 😅 😰
flub
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Endpoint::remote_infowhich returnsOption<RemoteInfo>. TheRemoteInfoexposes an iterator over all transport addrs for this remote that we know about.Fixes #3521
Breaking Changes
Notes & open questions
This basically copies the
RemotePathInfofrom the RemoteStateActor into a new structRemoteInfo. So, this an async fn over the channel to the RemoteStateActor, and allocates. As this is a rather niche API, I think that's fine.I wasn't entirely sure how much info we want to expose. Right now, the PR only includes the latest
Sourcefor the address, as I wasn't sure if we really want or need to expose the full list of sources.Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme