feat(iroh): add fast-apple-datapath feature and enable it by default#3724
Merged
dignifiedquire merged 1 commit intofeat-multipathfrom Dec 3, 2025
Merged
feat(iroh): add fast-apple-datapath feature and enable it by default#3724dignifiedquire merged 1 commit intofeat-multipathfrom
dignifiedquire merged 1 commit intofeat-multipathfrom
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3724/docs/iroh/ Last updated: 2025-12-02T15:18:04Z |
flub
approved these changes
Dec 3, 2025
| metrics = ["iroh/metrics", "iroh-metrics"] | ||
| local-relay = ["iroh/test-utils"] | ||
| # Use private Apple APIs to send multiple packets in a single syscall. | ||
| fast-apple-datapath = ["iroh/fast-apple-datapath", "quinn/fast-apple-datapath"] |
Contributor
There was a problem hiding this comment.
Not sure why you explicitly add quinn/fast-apple-datapath here as it should be pulled in vial the iroh/fast-apple-datapath feature. But it also doesn't do any harm.
Contributor
Author
There was a problem hiding this comment.
mostly because it is a direct dependency, I am never fully sure what to do in these cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.