Skip to content

refactor(iroh): remove stun-rs#3546

Merged
Frando merged 3 commits intomainfrom
Frando/remove-stunrs
Oct 16, 2025
Merged

refactor(iroh): remove stun-rs#3546
Frando merged 3 commits intomainfrom
Frando/remove-stunrs

Conversation

@Frando
Copy link
Copy Markdown
Member

@Frando Frando commented Oct 16, 2025

Description

iroh has stun-rs in its dependencies for a single type, TransactionId. stun-rs is causing some duplicate dependencies, so this removes stun_rs from the deps and instead inlines the single type we are using from it.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

@Frando Frando requested a review from dignifiedquire October 16, 2025 08:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 16, 2025 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3546/docs/iroh/

Last updated: 2025-10-16T10:25:14Z

@Frando Frando changed the title refactor: remove stun-rs refactor(iroh): remove stun-rs Oct 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 16, 2025 •
edited
Loading

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: aa6ac2c

@Frando Frando requested a review from flub October 16, 2025 09:08
@n0bot n0bot bot added this to iroh Oct 16, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Oct 16, 2025
flub
flub approved these changes Oct 16, 2025
View reviewed changes
@Frando Frando enabled auto-merge October 16, 2025 10:23
@Frando Frando added this pull request to the merge queue Oct 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2025
@Frando Frando added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit bafde6f Oct 16, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flub flub flub approved these changes

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

Assignees

No one assigned

Labels

None yet

Projects

iroh
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Frando @flub