fix(iroh): improve reusing of QAD reports#3512
Merged
dignifiedquire merged 7 commits intomainfrom Oct 14, 2025
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3512/docs/iroh/ Last updated: 2025-10-14T14:11:09Z |
0c4ada0 to
393ff7b
Compare
flub
reviewed
Oct 9, 2025
iroh/src/net_report.rs
Outdated
| match (state.have_v4, state.have_v6) { | ||
| (true, true) => { | ||
| // Both IPv4 and IPv6 are expected to be available | ||
| if num_ipv4 > 1 && num_ipv6 > 1 { |
Contributor
There was a problem hiding this comment.
>= perhaps? Or do you really want 2 each? same off-by-one question in the full report above.
Contributor
Author
There was a problem hiding this comment.
sigh, all of these should be >=....
flub
reviewed
Oct 9, 2025
iroh/src/net_report.rs
Outdated
|
|
||
| Some(timeout) | ||
| // If we have at least one probe per relay, we are happy | ||
| if num_total >= num_relays { |
Contributor
There was a problem hiding this comment.
does this case need to consider state.have_v4 and state.have_v6? E.g. if you have both and above doesn't yet return because its still waiting on ipv4 then this will return and no longer require ipv4?
Contributor
Author
There was a problem hiding this comment.
this needs to only look at https probes, you are right
8ee3389 to
4debb5f
Compare
flub
reviewed
Oct 14, 2025
4debb5f to
0c45244
Compare
flub
approved these changes
Oct 14, 2025
7cd0f47 to
9079c10
Compare
This splits v4 vs v6 QAD report reuse between runs, to reduce traffic and overall work
9079c10 to
7d27e70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This splits v4 vs v6 QAD report reuse between runs, to reduce traffic and overall work