Skip to content

refactor!: move examples deps to non-wasm dev deps#3509

Merged
rklaehn merged 1 commit intomainfrom
remove-examples-feature
Oct 8, 2025
Merged

refactor!: move examples deps to non-wasm dev deps#3509
rklaehn merged 1 commit intomainfrom
remove-examples-feature

Conversation

@rklaehn
Copy link
Copy Markdown
Contributor

@rklaehn rklaehn commented Oct 8, 2025 •
edited
Loading

Description

Move examples deps to non-wasm dev deps

This makes it possible to run most examples without the --features examples feature flag.

Breaking Changes

Feature examples was removed

Notes & open questions

Q: Should we do the same for the remaining examples? Can we?

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

@rklaehn
chore: Move examples deps to non-wasm dev deps
6805980 
This makes it possible to run most examples without the --features examples feature flag.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 8, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3509/docs/iroh/

Last updated: 2025-10-08T12:52:15Z

@dignifiedquire
Copy link
Copy Markdown
Contributor

dignifiedquire commented Oct 8, 2025

needs to adjust CI checks accordingly

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 8, 2025

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 3c7605b

@rklaehn
Copy link
Copy Markdown
Contributor Author

rklaehn commented Oct 8, 2025

needs to adjust CI checks accordingly

Why? CI works other than semver, which is correctly failing:

failure feature_missing: package feature removed or renamed

@dignifiedquire
Copy link
Copy Markdown
Contributor

dignifiedquire commented Oct 8, 2025

I thought we had an explicit --features examples in CI, but seems we don't

@dignifiedquire dignifiedquire changed the title chore: Move examples deps to non-wasm dev deps chore!: Move examples deps to non-wasm dev deps Oct 8, 2025
@dignifiedquire dignifiedquire changed the title chore!: Move examples deps to non-wasm dev deps refactor!: move examples deps to non-wasm dev deps Oct 8, 2025
dignifiedquire
dignifiedquire approved these changes Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@dignifiedquire dignifiedquire added this to the v0.93.0 milestone Oct 8, 2025
@n0bot n0bot bot added this to iroh Oct 8, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Oct 8, 2025
@rklaehn rklaehn added this pull request to the merge queue Oct 8, 2025
Merged via the queue into main with commit 81e340f Oct 8, 2025
54 of 57 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees

No one assigned

Labels

None yet

Projects

iroh
Status: ✅ Done

Milestone

v0.93.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rklaehn @dignifiedquire