fix(iroh): convert to canonical IP address in IpSender#3506
Merged
dignifiedquire merged 1 commit intomainfrom Oct 7, 2025
Merged
fix(iroh): convert to canonical IP address in IpSender#3506dignifiedquire merged 1 commit intomainfrom
dignifiedquire merged 1 commit intomainfrom
Conversation
Our AsyncUdpSocket is always an IPv6 socket, because we need to sent to our IPv6 ULAs for the mapped addresses. This means Quinn will convert any IPv4 destination into an IPv4-mapped IPv6 address (::ffff:a.b.c.d). But our sockets are bound to a specific family, so even if the OS supports and IPv6 socket that can handle IPv4 it will not accept those addresses. So when we are using the destinations we need to convert back to the canonical addresses in the IPSender.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3506/docs/iroh/ Last updated: 2025-10-07T13:17:59Z |
flub
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our AsyncUdpSocket is always an IPv6 socket, because we need to sent to our IPv6 ULAs for the mapped addresses. This means Quinn will convert any IPv4 destination into an IPv4-mapped IPv6 address (::ffff:a.b.c.d).
But our sockets are bound to a specific family, so even if the OS supports and IPv6 socket that can handle IPv4 it will not accept those addresses. So when we are using the destinations we need to convert back to the canonical addresses in the IPSender.
Based on 4eb0f07