-
Notifications
You must be signed in to change notification settings - Fork 382
bug: impl Discover for Arc<T> incorrect #3489
Copy link
Copy link
Closed
Description
Line 360 in 60d5310
| impl<T: Discovery> Discovery for Arc<T> {} |
The following line:
impl<T: Discovery> Discovery for Arc<T> {}
makes it so that if someone changes/incorrectly writes:
builder.add_discovery(|_| Arc::new(Foo)));
instead of
builder.add_discovery(|_| Foo);
the code suddenly does nothing because default impls for methods on Discovery will just ignore the T/Foo.
Line 32 in 60d5310
| //! reliable default choice. |
For whatever reason we did it in our code, and it was such a weird bug to debug. :D
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Status
✅ Done