refactor!: switch to iroh headers for captive portal checks#3488
Merged
refactor!: switch to iroh headers for captive portal checks#3488
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3488/docs/iroh/ Last updated: 2025-10-07T14:28:49Z |
flub
approved these changes
Oct 7, 2025
|
|
||
| const NO_CONTENT_CHALLENGE_HEADER: &str = "X-Tailscale-Challenge"; | ||
| const NO_CONTENT_RESPONSE_HEADER: &str = "X-Tailscale-Response"; | ||
| // TODO: remove before 1.0 |
Contributor
There was a problem hiding this comment.
Please link to an issue linked to the milestone.
| const NO_CONTENT_RESPONSE_HEADER: &str = "X-Tailscale-Response"; | ||
| // TODO: remove before 1.0 | ||
| const NO_CONTENT_CHALLENGE_HEADER_LEGACY: &str = "X-Tailscale-Challenge"; | ||
| const NO_CONTENT_CHALLENGE_HEADER: &str = "X-Iroh-Challenge"; |
Contributor
There was a problem hiding this comment.
Seeing "Iroh" capitalised is jarring 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches to use
X-Irohinstead ofX-Tailscaleheaders for the captive portal challenges.Old headers are preserved on the
iroh-relayside, until we do more breaking changes.Breaking Changes
The challenges for captive portals need to be sent to the latest version of
iroh-relay