chore: bump some spans up to warn, to ensure they are logged#3466
Merged
dignifiedquire merged 1 commit intomainfrom Sep 29, 2025
Merged
chore: bump some spans up to warn, to ensure they are logged#3466dignifiedquire merged 1 commit intomainfrom
dignifiedquire merged 1 commit intomainfrom
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3466/docs/iroh/ Last updated: 2025-09-26T11:02:59Z |
flub
approved these changes
Sep 26, 2025
| } | ||
| } | ||
| .instrument(debug_span!("handler")) | ||
| .instrument(warn_span!("handler")) |
Contributor
There was a problem hiding this comment.
Not that this does any harm, but a span without fields is perhaps not that interesting?
Contributor
Author
There was a problem hiding this comment.
potentially, but we have quite a few of these currently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were missing this information in some logs
Breaking Changes
None
Notes & open questions
Unclear if we should normalize differently, but this fixes the concrete issue for now.