Skip to content

feat: upgrade to rand@0.9#3465

Merged
dignifiedquire merged 16 commits intomainfrom
feat-rand-09
Oct 6, 2025
Merged

feat: upgrade to rand@0.9#3465
dignifiedquire merged 16 commits intomainfrom
feat-rand-09

Conversation

@dignifiedquire
Copy link
Copy Markdown
Contributor

@dignifiedquire dignifiedquire commented Sep 25, 2025 •
edited
Loading

Description

  • Upgrade to rand@0.9
  • Upgrade dalek crates to prereleases

Blocked on

Closes #3198

Breaking Changes

  • interfaces that depend on rand now need 0.9

Notes & open questions

@n0bot n0bot bot added this to iroh Sep 25, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Sep 25, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 25, 2025 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3465/docs/iroh/

Last updated: 2025-10-06T11:06:54Z

@dignifiedquire dignifiedquire self-assigned this Sep 25, 2025
@dignifiedquire dignifiedquire added this to the v0.99.0 milestone Sep 29, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 29, 2025 •
edited
Loading

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: fc975f4

@dignifiedquire dignifiedquire force-pushed the feat-rand-09 branch 3 times, most recently from a8347a9 to b635926 Compare October 2, 2025 10:23
@dignifiedquire dignifiedquire modified the milestones: v0.99.0, v1.0.0 Oct 2, 2025
@ramfox ramfox modified the milestones: v1.0.0, v0.99.0 Oct 2, 2025
@Arqu
Copy link
Copy Markdown
Collaborator

Arqu commented Oct 3, 2025

@dignifiedquire there's been some requests for this on the public discord, maybe we should try to move forward on it.

@dignifiedquire
Copy link
Copy Markdown
Contributor Author

dignifiedquire commented Oct 3, 2025

@dignifiedquire there's been some requests for this on the public discord, maybe we should try to move forward on it.

I am blocked on a mainline and crypto_box release currently

@dignifiedquire dignifiedquire changed the title [wip] feat: upgrade to rand@0.9 feat: upgrade to rand@0.9 Oct 6, 2025
@dignifiedquire dignifiedquire marked this pull request as ready for review October 6, 2025 08:20
@dignifiedquire dignifiedquire modified the milestones: v1.0.0, v0.93.0 Oct 6, 2025
@dignifiedquire dignifiedquire requested review from Frando and flub October 6, 2025 10:22
Arqu
Arqu reviewed Oct 6, 2025
View reviewed changes
iroh/src/discovery/mdns.rs
#[tokio::test]
#[traced_test]
async fn mdns_subscribe() -> Result {
let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(0u64);
Copy link
Copy Markdown
Collaborator

@Arqu Arqu Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly annoying having these now all over the place

Arqu
Arqu approved these changes Oct 6, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean LGTM, but that constant seed innit is a bit annoying and will probably flow into the rest of the crates too. I kinda know it would be bad practice to make the rng an option on that generate func and default a seed when not provided, but seems alluring here.

flub
flub approved these changes Oct 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoa, that's a lot of changes

@dignifiedquire dignifiedquire added this pull request to the merge queue Oct 6, 2025
Merged via the queue into main with commit 78649a3 Oct 6, 2025
53 of 54 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Oct 6, 2025
@dignifiedquire dignifiedquire deleted the feat-rand-09 branch October 6, 2025 11:32
@qykr qykr mentioned this pull request Oct 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flub flub flub approved these changes

@Arqu Arqu Arqu approved these changes

@Frando Frando Awaiting requested review from Frando

Assignees

@dignifiedquire dignifiedquire

Labels

None yet

Projects

iroh
Status: ✅ Done

Milestone

v0.93.0

Development

Successfully merging this pull request may close these issues.

deps: update to rand@0.9 and getrandom@0.3

4 participants

@dignifiedquire @Arqu @flub @ramfox