Conversation
BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
voxpelli
left a comment
There was a problem hiding this comment.
What in this PR is actually needed to support ESLint 8?
Much if this PR seems like general maintenance and that's best kept separate from the core change to make the core change as small and focused and reviewable and mergeable as possible.
Eg: Changing the CI definition more than explicitly needed while introducing other changes makes it harder to know if this breaks anything or whether the CI definition isn't testing properly anymore.
| }, | ||
| "peerDependencies": { | ||
| "eslint": ">=5" | ||
| "eslint": "^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0" |
There was a problem hiding this comment.
This change isn't needed to support ESLint 8?
| }, | ||
| "dependencies": { | ||
| "eslint-visitor-keys": "^2.0.0" | ||
| "eslint-visitor-keys": "^3.0.0" |
There was a problem hiding this comment.
It's developed to be compatible with ESLint 8, so that's why I updated
818770a to
80cb4de
Compare
|
For people watching this PR: we've already started with our own fork in order to not hold the wider community back anymore: https://github.com/eslint-community/eslint-utils @mysticatea We would still love to move the original repo to the new https://github.com/eslint-community though. This PR is released in |
ESLint v8.0.0 is released 🎉
devDependency compatibility with ESLint 8:
@mysticatea/eslint-plugin(Support ESLint 8.x eslint-plugin#31)BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
Closes #33