Use nodejs native abort-controller if available#27
Open
martinheidegger wants to merge 1 commit intomysticatea:masterfrom
Open
Use nodejs native abort-controller if available#27martinheidegger wants to merge 1 commit intomysticatea:masterfrom
martinheidegger wants to merge 1 commit intomysticatea:masterfrom
Conversation
Author
|
Node 16.3 has been released in the meantime. |
|
We see the same problem with Node 18 + TypeScript 4.9. |
|
Same here, @taras did you find any workaround? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 15 added
AbortControllerandAbortSignalto theglobalscope.This PR adds a
./node.jsfile that will use node.js globals if available and else falls back to the shim.Note: I found it really hard to export AbortController as default AND add the AbortController/AbortSignal properties to it without extending AbortController so I dropped it. Sadly, this means that this PR is a breaking change as the default value is not available anymore.
Closes #24