rocketmq-remoting/src/remoting_server/server.rs (3)

Line range hint 31-39: Potential typo in do_after_rpc_hooks method; should call do_after_request

In the do_after_rpc_hooks method, you are calling hook.do_before_request(...), which appears to be a typo. Since this method is for executing hooks after the request is processed, it should call hook.do_after_request(...) instead.

Update the method as follows:

pub fn do_after_rpc_hooks(
    &self,
    channel: &Channel,
    response: &mut RemotingCommand,
) -> Result<()> {
    for hook in self.rpc_hooks.iter() {
-       hook.do_before_request(channel.remote_address(), response)?;
+       hook.do_after_request(channel.remote_address(), response)?;
    }
    Ok(())
}

---

Line range hint 199-253: Simplify the handle_error function's control flow

The handle_error function contains nested match statements that can make the code harder to read and maintain. Refactoring the function to simplify the control flow can improve readability.

Refactored handle_error function:

async fn handle_error(
    &mut self,
    oneway_rpc: bool,
    opaque: i32,
    exception: Option<Error>,
) -> HandleErrorResult {
    if exception.is_none() {
        return HandleErrorResult::GoHead;
    }

    if oneway_rpc {
        return HandleErrorResult::Continue;
    }

    let exception_inner = exception.unwrap();
    let response = match exception_inner {
        Error::AbortProcessException(code, message) => {
            RemotingCommand::create_response_command_with_code_remark(code, message)
        }
        _ => {
            RemotingCommand::create_response_command_with_code_remark(
                ResponseCode::SystemError,
                exception_inner.to_string(),
            )
        }
    };

    if let Err(err) = self
        .connection_handler_context
        .channel
        .connection
        .writer
        .send(response.set_opaque(opaque))
        .await
    {
        if let Error::Io(io_error) = err {
            error!("Send response failed: {}", io_error);
            return HandleErrorResult::ReturnMethod;
        } else {
            error!("Send response failed: {}", err);
        }
    }

    HandleErrorResult::Continue
}

---

186-191: Improve error messages when sending responses fails

Providing more detailed error messages can help with troubleshooting network issues or unexpected disconnections. Include the remote address in the log for better context.

Update the error handling as follows:

match err {
    Error::Io(io_error) => {
-       error!("connection disconnect: {}", io_error);
+       error!("Connection to {} disconnected: {}", self.channel.remote_address(), io_error);
        return Ok(());
    }
    _ => {
-       error!("send response failed: {}", err);
+       error!("Failed to send response to {}: {}", self.channel.remote_address(), err);
    }
}

Configuration used: .coderabbit.yaml
Review profile: CHILL