[ISSUE #1607]♻️Remove Rebalance trait useless method remove_unnecessary_pop_message_queue_pop🔥 (#1608)

mxsm · web-flow · commit e697e43bcb0f · 2024-12-06T17:31:31.000+08:00
diff --git a/rocketmq-client/src/consumer/consumer_impl/re_balance.rs b/rocketmq-client/src/consumer/consumer_impl/re_balance.rs
@@ -44,12 +44,6 @@ pub trait RebalanceLocal {
     ) -> bool;
 
     fn remove_unnecessary_pop_message_queue(
-        &mut self,
-        mq: &MessageQueue,
-        pq: &PopProcessQueue,
-    ) -> bool;
-
-    fn remove_unnecessary_pop_message_queue_pop(
         &mut self,
         _mq: &MessageQueue,
         _pq: &PopProcessQueue,
diff --git a/rocketmq-client/src/consumer/consumer_impl/re_balance/rebalance_push_impl.rs b/rocketmq-client/src/consumer/consumer_impl/re_balance/rebalance_push_impl.rs
@@ -243,14 +243,6 @@ impl Rebalance for RebalancePushImpl {
         }
     }
 
-    fn remove_unnecessary_pop_message_queue(
-        &mut self,
-        mq: &MessageQueue,
-        pq: &PopProcessQueue,
-    ) -> bool {
-        todo!()
-    }
-
     fn consume_type(&self) -> ConsumeType {
         ConsumeType::ConsumePassively
     }

Original file line number	Diff line number	Diff line change
`@@ -243,14 +243,6 @@ impl Rebalance for RebalancePushImpl {`
`243`	`243`	`}`
`244`	`244`	`}`
`245`	`245`
`246`		`- fn remove_unnecessary_pop_message_queue(`
`247`		`- &mut self,`
`248`		`- mq: &MessageQueue,`
`249`		`- pq: &PopProcessQueue,`
`250`		`- ) -> bool {`
`251`		`- todo!()`
`252`		`- }`
`253`		`-`
`254`	`246`	`fn consume_type(&self) -> ConsumeType {`
`255`	`247`	`ConsumeType::ConsumePassively`
`256`	`248`	`}`