refactor: Apple Maps, performance fixes, dead code removal#32
Merged
Conversation
- Replace custom Seelenreich tile overlay with native Apple Maps (Standard/Satellite/Hybrid) - Add packetIdToAllIndex for O(1) message lookups instead of O(n) linear scans - Cache NSDataDetector as static let instead of recreating per message render - Fix MapView O(n²) annotation updates with dictionary lookup - Use stable DebugLine IDs in ForEach instead of unstable .offset - Cache notification authorization to avoid re-requesting on every DM - Store NotificationCenter observer token and clean up in deinit - Remove dead code: ContentView.swift, empty setupBLEScanner(), TileDownloaderSheet, ZipImportSheet - Remove unused tile server URL settings from SettingsService Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
MapView.swift— Native Apple Maps, removed CachedTileOverlay and tile overlay logicAppState.swift— AddedpacketIdToAllIndexfor O(1) lookups, stableDebugLinestructSharedMessageViews.swift— CachedNSDataDetectoras static letAppCoordinator.swift— Stored NotificationCenter observer, removed empty setupBLEScannerMeshHessenApp.swift— Cached notification authorization stateSettingsService.swift— Removed unused tile URL propertiesSettingsView.swift— Updated Map settings to Apple Maps stylesDebugView.swift— Stable ForEach identity using DebugLine.idContentView.swift,TileDownloaderSheet.swift,ZipImportSheet.swiftTest plan
🤖 Generated with Claude Code