fix(skills): add sqlite missing-mirror guard guidance#2819
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 require-ready-label-and-ciWonderful, this rule succeeded.
|
Greptile SummaryThis PR adds a missing-mirror guard for SQLite-backed novel commands, ensuring that when the local store hasn't been populated yet (i.e., the user hasn't run
Confidence Score: 5/5Safe to merge — the change is purely additive documentation and guidance, with no modification to existing logic or interfaces. Both changed files are documentation and tests. The SKILL.md prose correctly positions the guard after all earlier exit gates (help probe, dry-run, required-input, dbPath resolution), the skeleton reflects that order verbatim, and the new test pins the key strings and their relative ordering in the document. No runtime code paths are altered. No files require special attention. Important Files Changed
|
6bb6b8b to
508cbdf
Compare
Merge Queue Status
This pull request spent 9 minutes 19 seconds in the queue, including 9 minutes 2 seconds running CI. Waiting for
All conditions
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 23 minutes 8 seconds in the queue, including 22 minutes 43 seconds running CI. Required conditions to merge
|
Summary
SQLite-backed novel-command guidance now gives agents a copyable missing-mirror guard for first-run live executions, scoped to commands that read the local store. The store-query skeleton now checks
dbPathbefore opening SQLite and returns[]for--json/--agentwhile giving humans a sync hint.Closes #2393
Tests
go test ./internal/cli -run 'TestPrintingPressSkill|TestInternalSkillMinimumBinaryVersionsTrackMajor' -count=1go test ./internal/pipeline -run 'TestLiveCheck_(PassOnQueryOnlyJSONOutput|FailOnIrrelevantOutput)$' -count=1go test ./...failed ininternal/pipeline:TestLiveCheck_PassOnQueryOnlyJSONOutputandTestLiveCheck_FailOnIrrelevantOutputtimed out after 5s during the full-suite run; both passed on targeted rerun.