Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 require-ready-label-and-ci

Greptile Summary

This PR closes a second-order bypass in the MCP SQL read-only gate: a SELECT-prefix query like SELECT 1; ATTACH DATABASE ... previously passed the allowlist check because the leading keyword was valid, even though the semicolon-separated tail contained a mutating statement. The fix adds hasTrailingSQLStatement, a byte-level scanner that respects all five SQLite quoting contexts (', ", `, [...], /* */, --), and calls it on the stripped query before the SELECT/WITH prefix check.

• hasTrailingSQLStatement is added to the template and propagated to all four golden output files; the generator test now also asserts the generated package compiles via requireGeneratedCompiles.
• New test vectors cover the exact attack payloads (multi-statement with ATTACH DATABASE, DROP TABLE, VACUUM INTO, and CTE form), as well as legitimate queries where semicolons appear inside string literals or identifiers.

Confidence Score: 5/5

The change is safe to merge — it tightens the existing security gate without altering any passing behavior, and all four generated golden outputs are updated consistently.

The new hasTrailingSQLStatement byte scanner is logically sound: it correctly tracks all five SQLite quoting contexts, the early-return on the first terminator-with-no-trailing-SQL is safe because stripLeadingSQLNoise (called as the trailing check) itself strips nested semicolons and noise, and the generator test now enforces both symbol presence and successful compilation of the emitted code.

No files require special attention.

Important Files Changed

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[handleSQL receives query] --> B[validateReadOnlyQuery]
    B --> C[stripLeadingSQLNoise\nremove leading whitespace,\ncomments, semicolons]
    C --> D{hasTrailingSQLStatement?}
    D -- true --> E[error: only a single\nSELECT or WITH statement\nis allowed]
    D -- false --> F{HasPrefix SELECT\nor WITH?}
    F -- false --> G[error: only SELECT\nqueries are allowed]
    F -- true --> H[OpenReadOnly DB\nmode=ro]
    H --> I[Execute query]

_{Reviews (2): Last reviewed commit: "fix(cli): clarify sql mcp validation mes..." | Re-trigger Greptile}

Merge Queue Status

• ✅ Entered queue — 2026-06-07 20:10 UTC · Rule: default
• ✅ Checks passed · on draft merge queue: embarking main (2a98ea1), #2814, #2808 and #2811 together #2840
• ✅ Merged — 2026-06-07 20:37 UTC · at d5013f1e55b63bf07c01a6e2ebf9b8de4a29b609 · squash

This pull request spent 26 minutes 53 seconds in the queue, including 22 minutes 13 seconds running CI.